Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsemrtd.js.org #9225

Merged
merged 2 commits into from
Sep 3, 2024
Merged

tsemrtd.js.org #9225

merged 2 commits into from
Sep 3, 2024

Conversation

li0ard
Copy link
Contributor

@li0ard li0ard commented Sep 3, 2024

cnames_active.js Outdated
@@ -3236,6 +3236,7 @@ var cnames_active = {
"ts2jsdoc": "spatools.github.io/ts2jsdoc", // noCF? (don´t add this in a new PR)
"tsch": "type-challenges.netlify.app",
"tsdi": "knisterpeter.github.io/tsdi",
"tsemrtd": "li0ard.is-cool.dev/tsemrtd",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot target a subdirectory of an arbitrary domain (we only track the directory for GitHub repositories specifically)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, i'll fix that

@li0ard
Copy link
Contributor Author

li0ard commented Sep 3, 2024

Fixed

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Sep 3, 2024
@MattIPv4 MattIPv4 changed the title Update cnames_active.js tsemrtd.js.org Sep 3, 2024
@li0ard
Copy link
Contributor Author

li0ard commented Sep 3, 2024

image
Added

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/li0ard/tsemrtd/blob/main/README.md

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Sep 3, 2024
@indus
Copy link
Member

indus commented Sep 3, 2024

Welcome https://tsemrtd.js.org

@indus indus merged commit e4059b2 into js-org:master Sep 3, 2024
1 check passed
@li0ard
Copy link
Contributor Author

li0ard commented Sep 3, 2024

Thx so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants